Skip to content

Add it blame-copy-royal #2041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

cruessler
Copy link
Contributor

This is a draft PR. It is mostly intended for early feedback, in case there’s any. I plan on addressing the remaining TODOs over the course of the coming days. I also plan on providing more context. :-)

@Byron
Copy link
Member

Byron commented Jun 9, 2025

Thanks for making this happen!

Early feedback could be that this seems to be a breaking change in gix-blame, which should then go into a separate commit. I didn't look at it beyond that though.

@cruessler cruessler force-pushed the add-blame-extraction branch 3 times, most recently from 039d300 to 6c6c733 Compare June 15, 2025 11:10
@cruessler cruessler force-pushed the add-blame-extraction branch from 6c6c733 to 01cd9bd Compare June 15, 2025 14:09
@cruessler cruessler force-pushed the add-blame-extraction branch from 01cd9bd to b01d624 Compare June 15, 2025 16:43
@cruessler cruessler marked this pull request as ready for review June 20, 2025 06:52
@cruessler
Copy link
Contributor Author

@Byron I think I’ve now reached a point where it makes sense for you to start reviewing!

I tried to add as much context as possible in comments. I hope that’s enough context, let me know if you need more! I also tried to have each commit only touch a single crate. Feel free to squash if you want!

What I wasn’t sure about was the command’s name. This initial version basically just copies the name from copy-royal because it seems somehow related. Another option that might work is extract-blame-history.

I will continue testing the PR in the background. My gut feeling tells me that, at this point, any issues I might still find could also be issues in the blame implementation itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants